Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance About Us page with glassmorphism effect for better visual appeal #120

Closed
wants to merge 1 commit into from

Conversation

DatHoang102003
Copy link

Hi,

I saw that another contributor has already submitted a pull request for this issue, and his solution looks great! However, I’ve also worked on this enhancement and would like to submit my version of the glassmorphism effect for the "About Us" page. I believe my version brings a slightly different approach that might offer another option for the team to consider.

I’ve attached a screenshot of the page for review, and I’m happy to make any adjustments based on feedback.

Thanks for the opportunity!
Screenshot 2024-10-09 190811

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening a pull request @DatHoang102003. We'll will review it as soon as possible 🙌❤️

Copy link
Owner

@Virtual4087 Virtual4087 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main concern is the color of the text container. It doesn't go too well with the background. If you can come up with some design to make it fit better with the background, I would gladly merge it.

@DatHoang102003
Copy link
Author

Hi Virtual4087,

Thanks for the feedback! I've made updates to the text container to address your concerns about the color. I’ve darkened the background of the text container and adjusted the glass effect to better blend with the page background.
Here’s a screenshot of the updated design:
image
Let me know what you think, and if this works for you!

Copy link
Owner

@Virtual4087 Virtual4087 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you misunderstood what I meant. By background, I mean the whole background where the Image and the text is contained. It doesn't blend in with the background. You can discard the glass effect and just try to work on that.

@DatHoang102003
Copy link
Author

Oh I'm understand, thank you for the clarify, gonna work on that now

Copy link
Owner

@Virtual4087 Virtual4087 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DatHoang102003 I'll be closing this pr since the issue has already been solved but feel free to create more issues if you want. I'll make sure to assign them to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants